Skip to content

supporting cc, bcc, from and categories fields are optional. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 26, 2018

Conversation

sachin-maheshwari
Copy link
Contributor

payload would be like -

{
"topic": "email.project.created",
"originator": "tc-notifications",
"timestamp": "2018-04-06T00:00:00",
"mime-type": "application/json",
"payload": {
"data": {
"subject": "3001032",
"name": "sachin m"
},
"recipients" : ["tc@mailinator.com"],
"from" : "tc@topcoder.com",
"categories" : ["a", "b"],
"cc" : ["cc@topcoder.com"],
"bcc": ["bcc@topcoder.com"]
}
}

@vikasrohit
Copy link

@sachin-maheshwari Can we support detailed form for from , ReplyTo and cc fields as suggested in https://github.com/sendgrid/sendgrid-nodejs/blob/master/packages/mail/USE_CASES.md#flexible-email-address-fields?

@sachin-maheshwari
Copy link
Contributor Author

sachin-maheshwari commented Apr 25, 2018

You mean following ?
//Email address with name
to: 'Some One someone@example.org'

That is default support as I tried...

{
"topic": "email.project.created",
"originator": "tc-notifications",
"timestamp": "2018-04-06T00:00:00",
"mime-type": "application/json",
"payload": {
"data": {
"subject": "3001032",
"name": "sachin m"
},
"recipients" : ["sachin <sachin@gmail.com>"],
"from" : "support <tc@topcoder.com>",
"cc" : ["cc@topcoder.com"]
}
}

@vikasrohit
Copy link

No, I meant

//Object with name/email
  to: {
    name: 'Some One',
    email: 'someone@example.org',
  },

@sachin-maheshwari
Copy link
Contributor Author

That is also supported you can try this.

@vikasrohit
Copy link

vikasrohit commented Apr 25, 2018

Awesome. I would try. Would try the changes in dev.

@sachin-maheshwari sachin-maheshwari merged commit 5051b36 into master Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants